[
https://issues.apache.org/jira/browse/CRUNCH-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Wills updated CRUNCH-157:
------------------------------
Description: We often use a pattern of nested DoFns-- DoFns that are
composed of operations on other DoFns. There is currently an ambiguity around
the right way to initialize those DoFns, since it can be done either via
overriding the initialize() or the setContext() methods in DoFn. We should
separate the calls to setContext and initialize to remove the ambiguity and fix
the instances in Crunch core where we override setContext() instead of
initialize(). (was: We often use a pattern of nested DoFns-- DoFns that are
composed of operations on other DoFns. There is currently an ambiguity around
the right way to initialize those DoFns, since it can be done either via
overriding the initialize() or the setContext() methods in DoFn. We should mark
setContext as final in order to remove the ambiguity and fix the instances in
Crunch core where we override setContext() instead of initialize().)
> Call DoFn.initialize directly, instead of from setContext
> ---------------------------------------------------------
>
> Key: CRUNCH-157
> URL: https://issues.apache.org/jira/browse/CRUNCH-157
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.3.0, 0.4.0
> Reporter: Josh Wills
> Assignee: Josh Wills
> Fix For: 0.5.0
>
> Attachments: CRUNCH-157.patch, CRUNCH-157-sep.patch
>
>
> We often use a pattern of nested DoFns-- DoFns that are composed of
> operations on other DoFns. There is currently an ambiguity around the right
> way to initialize those DoFns, since it can be done either via overriding the
> initialize() or the setContext() methods in DoFn. We should separate the
> calls to setContext and initialize to remove the ambiguity and fix the
> instances in Crunch core where we override setContext() instead of
> initialize().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
