Hi Ferenc, I changed my webrev to use constant1 / constant2 instead of SHA1WORD in kcf_random.c and swrand.c.
Updated webrev is posted. Thanks! Hai-May Ferenc Rakoczi wrote: > Hi, Hai-May, > > I have just one obserwation: at the beginning of the file, where > HASHSIZE is defined, one gets the impression that it is SHA1 > for now, but later can be changed to something else. In the spirit > of this, I would use HASHSIZE / sizeof(uint32_t) in the comparison > (and also in the declaration of the arrays in lines 618 and 619 > of kcf_random.c and line 323 of swrand.c) instead of SHA1WORDS. > These are constants, so the compiled code will be exactly the same, > but it shows the connection between the sizes of the arrays and the > size of the hash. > > Thanks, > Ferenc > > On 02/05/09 17:17, Hai-May Chao wrote: > >> Hi, >> >> I need a code review for >> >> 6799258 Continuous RNG test sometimes fails to compare 160-bit blocks >> >> The webrev is at: >> http://cr.opensolaris.org/~haimay/CR6799258/ >> >> Thanks, >> Hai-May >> >> >> >> _______________________________________________ >> crypto-discuss mailing list >> crypto-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss >> >> > _______________________________________________ > crypto-discuss mailing list > crypto-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/crypto-discuss > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/crypto-discuss/attachments/20090205/5d766b79/attachment.html>
