Think missed something first time. :)
usr/src/lib/libcryptoutil/common/tohexstr.c:
dkn-1: NIT - *blen and **bytes not set consistently on error return
line 74, *blen and **bytes not set
line 86, *blen set to 0, but **bytes is not set (coming from line 94)
line 120, *blen set to 0 and **bytes set to NULL
Shouldn't be issue if caller checks return value and avoids using
*blen and **bytes if return value is non-zero. Can't be too sure tho.
D.
Anthony Scarpino wrote:
> I'm unsure if the updates to the libcryptoutil portion of the zfs-crypto
> project were made available.. Dan A and Dina reviewed the original
> changes if I remember correctly.. Anyway, I've put the updates on:
>
> http://cr.opensolaris.org/~izick/libcryptoutil/
>
> These changes are independent and will be going back ahead of the zfs
> crypto putback..
>
> Tony
> _______________________________________________
> crypto-discuss mailing list
> crypto-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss
