Dan Anderson wrote:
> DEA-1 usr/src/common/crypto/dh/Makefile.html
> You need a rm line before the mv line on line 38:
>> $(RM) dh_impl.c
> 38 $(MV) dh_impl.c+ dh_impl.c
>
>
> DEA-2 usr/src/lib/pkcs11/libsoftcrypto/Makefile.sdiff.html
> I see no changes to this file (except copyright)--it should be removed from
> the list.
Yes.
>
> DEA-3 usr/src/common/crypto/padding/padding.h.html
> I assume these defines are overloaded on purpose:
> 39 #define PKCS1_ENCRYPT 0x02
> 40 #define PKCS1_DECRYPT 0x02
> 41 #define PKCS1_SIGN 0x01
> 42 #define PKCS1_VERIFY 0x01
>
Yes, but since it's not obvious, I should comment why.
Or combine them?
#define PKCS1_ENCR_DECR 0x02
#define PKCS1_SIGN_VRFY 0x01
>
> DEA-4 usr/src/lib/pkcs11/pkcs11_kernel/common/kernelKeys.c
> Ignored, as requested
This time around. :)
Thanks.
D.
