Am 03.07.2015 um 13:53 schrieb Jeffrey Walton: > > > On Friday, July 3, 2015 at 6:13:53 AM UTC-4, jean-pierre.muench wrote: > > Hey Jeff, > > Looks good by itself, but I'm not sure about putting it in > config.h, as it isn't a config option. > I'd rather put it in misc.h, as IIRC all of our tools (like rotate > and other stuff) live there. > > If it needs to be in config.h, for some very good reason it's ok, > but rather put it in the place where it's supposed to be. > > OK, good point. > > How about cryptlib.h? I believe its included by all source files > (unlike misc.h): > Well, it's better than config.h, but still *feels* wrong. cryptlib.h defines all major base-classes and namespaces and this stuff, but "tools" aren't included. IMO misc.h is still the best place for this.
Do you have a list of files, which would profit from COUNTOF, so I can make a better guess if it's really necessary to include it in cryptlib.h? BR JPM > $ git diff cryptlib.h > diff --git a/cryptlib.h b/cryptlib.h > index 4068722..8863357 100644 > --- a/cryptlib.h > +++ b/cryptlib.h > @@ -1650,6 +1650,14 @@ typedef SimpleKeyAgreementDomain > PK_SimpleKeyAgreementDom > typedef AuthenticatedKeyAgreementDomain > PK_AuthenticatedKeyAgreementDomain; > #endif > > +#define CRYPTOPP_UNUSED(x) ((void)x) // cast to void. > Portable way to > + > +#if defined(_MSC_VER) && (_MSC_VER >= 1400) // VS2005 > added _countof > +# defined COUNTOF(x) _countof(x) > +#else > +# define COUNTOF(x) (sizeof(x)/sizeof(x[0])) > +#endif > + > NAMESPACE_END > > #endif > > > > -- > -- > You received this message because you are subscribed to the "Crypto++ > Users" Google Group. > To unsubscribe, send an email to > [email protected]. > More information about Crypto++ and this group is available at > http://www.cryptopp.com. > --- > You received this message because you are subscribed to the Google > Groups "Crypto++ Users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME Cryptographic Signature
