On Thursday, July 23, 2015 at 9:10:46 AM UTC-4, Mouse wrote:
>
> My biggest concern is that the build control becomes more and more
> complicated. I don't really like it, as it could (a) deprive "normal" users
> from the ability to tweak it when needed, and (b) lay too heavy a burden on
> the project maintainers...
>
> One sed script won't turn the tide. But if more sad scripts would come...?
> ;)
>
Yeah, the thing I don't like is the makefile touching the configuration
file and touching defines the user may have modified. This is what I was
thinking with respect to sed... Break it out into two variables:
// DFW (don't fiddle with)!!! The makefile sets this based on your build
tools and settings!!!
// #define CRYTPOPP_CLANG_ASSEMBLER_MK
// Feel free to turn knobs on CRYTPOPP_CLANG_ASSEMBLER
#if defined(__clang__) && defined(CRYTPOPP_CLANG_ASSEMBLER_MK)
# define CRYTPOPP_CLANG_ASSEMBLER
#endif
Then, in GNUmakefile:
CLANG_ASSEMBLER ?= $(shell $(CXX) -xc -c /dev/null -Wa,-v -o/dev/null 2>&1
| $(EGREP) -i -c "^clang")
ifeq ($(CLANG_ASSEMBLER),0)
$(shell sed -i "s|^#define CRYTPOPP_CLANG_ASSEMBLER_MK|// #define
CRYTPOPP_CLANG_ASSEMBLER_MK|g" GNUmakefile)
else
$(shell sed -i "s|^// #define CRYTPOPP_CLANG_ASSEMBLER_MK|#define
CRYTPOPP_CLANG_ASSEMBLER_MK|g" GNUmakefile)
endif
Jeff
--
--
You received this message because you are subscribed to the "Crypto++ Users"
Google Group.
To unsubscribe, send an email to [email protected].
More information about Crypto++ and this group is available at
http://www.cryptopp.com.
---
You received this message because you are subscribed to the Google Groups
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
