I think this is the right way to deal with the situation at hand. Sent from my iPad
> On Nov 22, 2015, at 20:12, Jeffrey Walton <[email protected]> wrote: > > Hi Everyone, > > I talked with Wei about this. We basically took option (2) below. First we > started with a fresh ZIP file. Next we reverted the bad check-ins from both > Sourceforge and GitHub. We followed with a commit of the un-corrupted files. > Finally, we tagged the commits as CRYPTOPP_5_6_3. > > The commits are available at: > > * http://sourceforge.net/p/cryptopp/code/604 > * > http://github.com/weidai11/cryptopp/commit/298988a5b9687f64de733ce01319e90e94b0b688 > > The new ZIP is available at http://cryptopp.com/cryptopp563.zip. Here are the > new checksums: > > * SHA-1: f2fcd1fbf884bed70a69b565970ecd8b33a68cc4 > * SHA-256: 9390670a14170dd0f48a6b6b06f74269ef4b056d4718a1a329f6f6069dc957c9 > > My sincerest apologies for the confusion. > > Jeff > >> On Sunday, November 22, 2015 at 5:14:49 PM UTC-5, Jeffrey Walton wrote: >> Hi Everyone, >> >> I tested a check-out of 5.6.3 from version control. Its botched. >> >> It looks like a drag/drop from a VMware guest to my OS X host got mangled. >> There are about six or eight problems like these: >> >> --- a/ecp.h >> +++ b/ecp.h >> @@ -143,6 +143,3 @@ private: >> NAMESPACE_END >> >> #endif >> -E_END >> - >> -#endif >> >> And: >> >> --- a/seal.h >> +++ b/seal.h >> @@ -48,6 +48,3 @@ struct SEAL : public SEAL_Info<B>, public >> SymmetricCipherDocumentation >> NAMESPACE_END >> >> #endif >> -SPACE_END >> - >> -#endif >> >> Notice the tail of the file has extra garbage. >> >> This needs to be corrected before Monday morning. I think we have three >> options: >> >> (1) check-in the fix and call it 5.6.4 >> (2) ckeck-in the fix and call it 5.6.3 >> - re-tag check-in to CRYPTOPP_5_6_3 >> - rebuild ZIP to ensure consistent sources >> (3) check-in the fix and do nothing >> >> (3) is not a good option because it means folks who use CRYPTOPP_5_6_3 for >> their release engineering have a broken set of sources. > > -- > -- > You received this message because you are subscribed to the "Crypto++ Users" > Google Group. > To unsubscribe, send an email to [email protected]. > More information about Crypto++ and this group is available at > http://www.cryptopp.com. > --- > You received this message because you are subscribed to the Google Groups > "Crypto++ Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
smime.p7s
Description: S/MIME cryptographic signature
