I think that to create a new branch to the pull request I need contributor access. I'm right? Do you know how require that access? My github username is "andresgaragiola".
Regards On Thursday, January 14, 2016 at 4:32:58 PM UTC-3, Andrés Garagiola wrote: > > Excellent Jeff!!! > > Using: > > $make sources > > I'm updated DLLSRCS and the library compile without errors. I will proceed > with the pull request. > > Regards. > > On Thursday, January 14, 2016 at 1:38:48 PM UTC-3, Jeffrey Walton wrote: >> >> >> >> On Thursday, January 14, 2016 at 11:24:28 AM UTC-5, Jeffrey Walton wrote: >>> >>> >>> >>> On Thursday, January 14, 2016 at 9:25:02 AM UTC-5, Andrés Garagiola >>> wrote: >>>> >>>> A particular thing with this file is that I have this file "modexppc.h" >>>> but I don't have any file called "modexppc.cpp". >>>> >>>> Oh man, you're right. That cruft has probably been there for years. Its >>> present in 5.6.2 ( >>> http://www.cryptopp.com/docs/ref562/_g_n_umakefile_source.html#l00134), >>> but I did not check further back. >>> >>> Can you change DLLSRCS to use modexp.cpp and then test it? If it tests >>> OK, then can you make a pull request? >>> >>> (The pull request ensure you receive credit at >>> https://github.com/weidai11/cryptopp/graphs/contributors). >>> >> >> Something else you can do to gather up sources needed.... The makefile >> includes a recipe for 'sources' in an effort to provide a list of source >> files for Autotools, Cmake, etc. You can probably use it as a starting >> point: >> >> $ make sources >> Library sources: cryptlib.cpp cpu.cpp shacal2.cpp md5.cpp shark.cpp >> zinflate.cpp gf2n.cpp square.cpp ... rdrand.cpp eccrypto.cpp >> >> Test sources: bench.cpp bench2.cpp test.cpp validat1.cpp validat2.cpp >> validat3.cpp adhoc.cpp datatest.cpp regtest.cpp fipsalgt.cpp dlltest.cpp >> >> Jeff >> >> > -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
