On Saturday, April 23, 2016 at 11:25:28 PM UTC-4, Jeffrey Walton wrote: > > Committed at "Initial cut-in of CRYPTOPP_USE_FIPS_202_SHA3 macro", >>> http://github.com/weidai11/cryptopp/commit/df1c94a38a97119198aa3ae92e82ab9e46d4e9b5 >>> . >>> >>> That should get folks beyond the manual merging of patches. I still need >>> to add the test vectors, and they will be coming next >>> >> >> The test vectors were checked-in at "Add SHA3/FIPS 202 test vectors", >> http://github.com/weidai11/cryptopp/commit/01d137155ccbed6045a0ae5eb8eb02cbcaadbdca. >> >> A comment was added with the shell script to transform the NIST test >> vectors to Crypto++ test vectors. >> >> *If* CRYPTOPP_USE_FIPS_202_SHA3 is defined, then the validation suite >> ('cryptest.exe v') will run as expected. Ironically, the test vectors >> ('cryptest.exe tv all') will fail because a file named TestVectors/all.txt. >> is hard wired for the old tests. The file has been primed with the new >> tests, but it needs to be uncommented. >> > > It occurred to me... We can change test.cpp to account FIS 202 with: > > else if (command == "tv") > { > // TestDataFile() adds CRYPTOPP_DATA_DIR as required > std::string fname = (argv[2] ? argv[2] : "all"); > #if defined(CRYPTOPP_USE_FIPS_202_SHA3) > if (fname == "all") > fname = "all_fips_202"; > #endif > if (fname.find(".txt") == std::string::npos) > fname = "TestVectors/" + fname + ".txt"; > > PrintSeedAndThreads(seed); > return !RunTestDataFile(fname.c_str()); > } > > Then we supply a modified version of all.txt for the remainder of Crypto++ > 5.6.x. > > I'm in favor of it since it means my test scripts work without user > intervention. > > Is anyone opposed to it? >
I went ahead and committed this. The test scripts are too important. * http://github.com/weidai11/cryptopp/commit/3ee10576bb90ad0c143411b54ae7252dabd2c5d9 Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
