> I think we are at the point we can merge arm-neon and windows-store into > master. > > Both arm-neon and windows-store are clean compiling as separate branches. > I've tested arm-neon on-device, and its testing OK. I believe Геннадий has > tested windows-store on-device given the patches he has submitted. > > I also hand merged arm-neon into windows-store and tested a compile. The > combination tested OK. (As a side note, Visual Studio 2012 compilers and > above can consume NEON intrinsics, so BLAKE2_NEON_Compress32 and > BLAKE2_NEON_Compress64 are cross-platform. I also understand Microsoft's > compiler is quite good at optimizing for NEON, so I expect the benchmark > numbers for BLAKE2 will be very good for Windows Phone and Windows Store). > > Does anyone have any objections to merging arm-neon and windows-store into > master? >
The detection code was checked-in at http://github.com/weidai11/cryptopp/commit/01f77765d4387009d72b49f17721ddf103a0e753. The detection code only recognizes ARM, NEON, Windows Phone and Windows Store; and it only affects config.h, config.recommend, cpu.h and cpu.cpp. Adding the detection code to Master early makes it easier to test combinations like arm-neon merged into windows-store. It also allows us to test other unrelated source files, like SHA and ARMv8-a. The "meat and potatoes" of arm-neon and windows-store are the changes to source files, and they will be checked-in once it appears its OK. Jeff -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
