Many thanks Jefferey. The added documentation is very helpful. As you say, it seems difficult to protect against such misuse. I also thought about making the name ArraySink more advisory, e.g. something like FixedSizeArraySink. However, that appears unnecessarily verbose, as in C++ context, "Array" itself already indicates "fixed size". So it seems to me the added documentation should suffice.
On Friday, 14 April 2017 04:16:22 UTC+1, Jeffrey Walton wrote: > > > > On Thursday, April 13, 2017 at 8:53:15 AM UTC-4, Linmao Song wrote: >> >> I had the same issue as in this (very) old unanswered thread below. It >> took me quite a while to figure out why. In case it might help someone else >> puzzled by the same, the root cause is insufficient buffer size. >> Specifically, the "Shares[i]" should be made larger. >> >> ... >> >> On Friday, 11 December 2015 10:34:42 UTC, Whou Lee wrote: >>> >>> ... >>> I am trying to make CryptoPP::SecretSharing to work with in memory byte >>> objects. >>> My current solution partly works. I can reconstruct the original secret >>> except for the last byte or two, depends on the length of original secret. >>> Could you please suggest me how to fix this. >>> ... >>> >> > We added comments to the source code at > https://github.com/weidai11/cryptopp/commit/cf160e91c4e919d9. We also > added a note on ArraySink's wiki page at > https://www.cryptopp.com/wiki/ArraySink. > > Is there anything else we can do? > > Jeff > -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to [email protected]. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
