Thanks Steve. Would you mind also running mvn license:check and to format headers- license:format on the project(s) to verify the ASF License headers for any new files?
We'll see if we could start making the type system changes as soon as 3.0.0-incubating looks fairly stable with just all of the refactoring, namespaces, maven integration. > -----Original Message----- > From: Steven Bethard [mailto:[email protected]] > Sent: Thursday, October 04, 2012 10:40 PM > To: [email protected] > Subject: Re: location for SHARP Knowtator reader? > > The code is now here: > > ctakes- > core/src/main/java/org/apache/ctakes/core/ae/SHARPKnowtatorXMLReade > r.java > ctakes- > core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorAnnotati > on.java > ctakes- > core/src/main/java/org/apache/ctakes/core/knowtator/KnowtatorXMLPars > er.java > > I worked for a bit on filling in Knowtator/UIMA mappings in > SHARPKnowtatorXMLReader, but it's pretty tough, particularly without the > updates to the type system to add Generic, Conditional, Uncertainty, etc. > > You can get a flavor for many of the changes that need to be made to the > type system by scanning through all the TODO notes in that file... > > Steve > > > On Oct 2, 2012, at 12:38 PM, "Chen, Pei" <[email protected]> > wrote: > > > Either ctakes-core or ctakes-utils seems appropriate... > > > > --Pei > > > >> -----Original Message----- > >> From: Masanz, James J. [mailto:[email protected]] > >> Sent: Tuesday, October 02, 2012 2:30 PM > >> To: '[email protected]' > >> Subject: RE: location for SHARP Knowtator reader? > >> > >> > >> +1 for ctakes-core > >> > >> > >>> -----Original Message----- > >>> From: ctakes-dev-return-477- > >> [email protected] > >>> [mailto:ctakes-dev-return-477- > >> [email protected] > >>> rg] > >>> On Behalf Of Steven Bethard > >>> Sent: Tuesday, October 02, 2012 12:54 PM > >>> To: [email protected] > >>> Subject: location for SHARP Knowtator reader? > >>> > >>> Now that we've finally got the Apache repository working, I'd like > >>> to add the code for reading Knowtator XML annotations into the UIMA > >>> type > >> system. > >>> There are basically two pieces of this code, a generic parser for > >>> reading Knowtator XML files, and an AnalysisEngine that reads the > >>> Knowtator XML files created from the SHARP project and maps them to > >>> the cTAKES type > >>> system: > >>> > >>> https://github.com/bethard/ctakes- > >>> > >> > temporal/blob/master/src/main/java/org/apache/ctakes/knowtator/Knowt > >> at > >>> orXM > >>> LParser.java > >>> https://github.com/bethard/ctakes- > >>> > >> > temporal/blob/master/src/main/java/org/apache/ctakes/sharp/ae/Knowtat > >> o > >>> rXML > >>> Reader.java > >>> > >>> Where should these go? Maybe ctakes-core? The dependencies are > only > >>> the ctakes-type-system and JDOM. > >>> > >>> Steve
