Hi,
I haven't looked at this before, I guess I've been sloppy (or I didn't
care about gnome at the time)... but getting this kind of warning got
me intrigued:
/home/levitte/bzrwrk/ctwm/bzr/trunk/events.c:2200:32: warning: comparison
with string literal results in unspecified behavior [-Waddress]
/home/levitte/bzrwrk/ctwm/bzr/trunk/events.c:2207:32: warning: comparison
between pointer and integer
if(Event.xclient.message_type == XA_WIN_STATE) {
And even better:
In file included from /home/levitte/bzrwrk/ctwm/bzr/trunk/menus.c:100:0:
/home/levitte/bzrwrk/ctwm/bzr/trunk/menus.c: In function ‘Squeeze’:
/home/levitte/bzrwrk/ctwm/bzr/trunk/gnomewindefs.h:8:36: warning: passing
argument 3 of ‘XGetWindowProperty’ makes integer from pointer without a cast
#define XA_WIN_STATE "_WIN_STATE"
^
/home/levitte/bzrwrk/ctwm/bzr/trunk/menus.c:4575:42: note: in expansion of
macro ‘XA_WIN_STATE’
if(XGetWindowProperty(dpy, tmp_win->w, XA_WIN_STATE, 0L, 32, False,
^
In file included from /home/levitte/bzrwrk/ctwm/bzr/trunk/ctwm.h:71:0,
from /home/levitte/bzrwrk/ctwm/bzr/trunk/menus.c:83:
/usr/include/X11/Xlib.h:2676:12: note: expected ‘Atom’ but argument is of
type ‘char *’
extern int XGetWindowProperty(
^
Having a closer look, I can't quite understand how the macros
XA_WIN_STATE etc are useful... It does seem like, in this example,
_XA_WIN_STATE (initialised in gnome.c) should be used instead...
I do have a fleeting memory that the Gnome stuff was said to be half
baked way back when... maybe it's time to clean it up a bit...
--
Richard Levitte [email protected]
http://richard.levitte.org/
"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish
