On Wed, 6 Sep 2017 06:01:32 -0500 "Matthew D. Fuller" <[email protected]> wrote:
> On Wed, Aug 30, 2017 at 11:02:19PM -0400 I heard the voice of > Steve Litt, and lo! it spake thus: [snip] > > > > Either this is a bug in > > ctwm or there's a logic I'm just not seeing. > > Probably some of both. For further investigation of the why, I'd note > the change in that block in 3.3; prior to that the conditional was > simpler and only went into that block for the Workspaces menu. So it > seems like it may at least be in the "unexpected side effect" bug > bucket; 'd have to do a little more investigation of just what/why > that change was intended to affect to say for sure. > > I wouldn't expect to have a chance to look much at it myself soon, but > that should give anybody who does a starting point. For the time being I'm supplying a patch that turns "Return" into "Return_disabled" and calling it a workaround. As people start to use it, any side effects will show up pretty quickly, and those side effects can give clues about the real solution. I can't actually fix the root cause: I tried, but couldn't understand the code enough. [snip] > > I'm not sure what side effect that would be, because none of this > > code is executed unless the item->func is F_MENU, which I assume > > means "we're in a menu." > > Not exactly, if you mean "we're pressing the key while scrolling > through a menu"; that's already the case since we're in the > "if(ActiveMenu != NULL)" block of the KeyPress handler. It means "the > entry we're trying to invoke is a 'f.menu' call". > > Apart from the "top-level", where a mouse click or keypress calls up a > menu the first time, f.menu never gets executed like a normal > function. It winds up being pulled up by magic in that keypress > handler where you're looking, or by having the mouse pointer move into > the right third of the entry in the menu code where it internally > hijiacks the event loop. So there's plenty of magic hiding in there > to fuel nightmares... I'll give it some more thought after I've recovered from Hurricane Irma, which depending on exact course could either give me some great kite flying weather or rip down my house. Thanks, SteveT Steve Litt September 2017 featured book: Manager's Guide to Technical Troubleshooting Brand new, second edition http://www.troubleshooters.com/mgr
