On 04/24/2010 01:53 AM, Daniel Stenberg wrote:
On Mon, 19 Apr 2010, Ben Greear wrote:
Sorry for my delay on this.
Turns out, telnet on original curl didn't always flush stdout, so
there were still issues when using it interactively. Here's a patch
that flushes stdout when needed, and uses flags based on users setting
read or write callback instead of comparing function pointers or
requiring a new setopt.
Why flush stdout? libcurl didn't do it previously, and nobody has
complained about that. Anyone who would require flushing or any other
kind of tweaking of the output could very easily just provide their own
write callback, right? I think we should just leave the default output
like before.
Let me know what you think...I'll send an official git patch if you
concur with these changes.
I don't think we need the flushing, the rest looks fine to me!
Maybe just no one ever used it. You need the flush if you want to use 'curl'
as a telnet client of any useful nature..otherwise, you don't see the prompts
until after you enter data.
But, I can remove it if you really want it removed.
Thanks,
Ben
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
