Hi Daniel, I've just received your email regarding the v7.22.0 release through the distribution list and thought I should wake up this thread.
I just wanted to touch base and see how you want to proceed with this one: Did you have any more thoughts? Are you able to take a look at the patch? Did you want me to re-submit it against the latest codebase? Many thanks in advance Regards Steve -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Steve Holme Sent: 29 August 2011 6:29 PM To: 'libcurl development' Subject: RE: [PATCH] Curl_gethostname() may or may not return the hostname as a FQDN Hi Daniel, > Argh, that's correct. We don't have anything in libcurl before this > > If we decide not to modify Curl_resolv()'s underlying functions then I > would still recommend we modify the output of > Curl_gethostname() so it returns a defined value I don't know if you had any more thoughts about how the SMTP module should provide the fully qualified domain name to the connected server, but in the meantime I have prepared a patch for you that fixes Curl_gethostname() so that it always returns a defined output regardless of socket provider. The code checks for a full stop (period / dot) and only copies what is before it to the output buffer - this is essentially what the code in Curl_ntlm_msgs.c is doing. If you see fit to push this patch then we can tidy up the relevant code in NTLM afterwards as it does not presently break that code. Kind Regards Steve ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
