I'd like to fix this ASAP but what is the correct way of dealing with this? Is this an i386 failure or should code just not use bus_space_read_8() or bus_space_write_8() ?
In the VirtIO case, it doesn't have to be written atomically though. What I could do is define a bus_space_write_8() function that gets compiled for i386 only but that's a hack. Reinoud On Thu, Jan 21, 2021 at 07:59:03PM +0700, Robert Elz wrote: > Date: Wed, 20 Jan 2021 21:17:40 +0000 (UTC) > From: NetBSD Test Fixture <brac...@netbsd.org> > Message-ID: <161117746032.12857.11666628493575446...@babylon5.netbsd.org> > > | This is an automatically generated notice of a NetBSD-current/i386 > | build failure. > | > | The failure occurred on babylon5.netbsd.org, a NetBSD/amd64 host, > | using sources from CVS date 2021.01.20.19.46.48. > > The problem that caused that particular failure is fixed (martin@ > fixed the immediate problem, then I fixed a much older bug (2019 vintage) > that made martin's (correct) fix fail. > > But these commits are still responsible for the build (still) failing > > | The following commits were made between the last successful build and > | the failed build: > | > | 2021.01.20.19.46.48 reinoud src/sys/dev/acpi/virtio_acpi.c,v 1.5 > | 2021.01.20.19.46.48 reinoud src/sys/dev/fdt/virtio_mmio_fdt.c,v 1.5 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/if_vioif.c,v 1.66 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/ld_virtio.c,v 1.29 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/vio9p.c,v 1.3 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/viomb.c,v 1.12 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/viornd.c,v 1.14 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/vioscsi.c,v 1.25 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/virtio.c,v 1.43 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/virtio_pci.c,v 1.15 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/virtio_pcireg.h,v 1.1 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/virtioreg.h,v 1.7 > | 2021.01.20.19.46.48 reinoud src/sys/dev/pci/virtiovar.h,v 1.17 > | 2021.01.20.19.46.48 reinoud src/sys/dev/virtio/virtio_mmio.c,v 1.4 > > The most recent log is at: > > http://releng.netbsd.org/b5reports/i386/2021/2021.01.21.09.50.37/build.log.tail > > and contains the following error messages (all one underlying issue) > > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.o: in function `virtio_pci_setup_queue_10': > virtio_pci.c:(.text+0x1285): undefined reference to `bus_space_write_8' > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.c:(.text+0x12a9): undefined reference to `bus_space_write_8' > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.c:(.text+0x12cd): undefined reference to `bus_space_write_8' > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.c:(.text+0x132e): undefined reference to `bus_space_write_8' > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.c:(.text+0x1357): undefined reference to `bus_space_write_8' > /tmp/build/2021.01.21.09.50.37-i386/tools/bin/i486--netbsdelf-ld: > virtio_pci.o:virtio_pci.c:(.text+0x1380): more undefined references to > `bus_space_write_8' follow > > This is as far as I can go with this one, I don't know whether i386 is > supposed to have a bus_space_write_8() function or not (and if not, what > should be used instead) or whether it exists, but for some reason isn't > being found (the error is detected in the INSTALL kernel build), or > something else. > > kre
