Thanks. Basic and the added ones pass. Full vmtest run is pending. Diff comments:
> diff --git a/examples/tests/reuse-msdos-partitions.yaml > b/examples/tests/reuse-msdos-partitions.yaml > new file mode 100644 > index 0000000..bc1dbf1 > --- /dev/null > +++ b/examples/tests/reuse-msdos-partitions.yaml > @@ -0,0 +1,135 @@ > +showtrace: true > +install: > + unmount: disabled > + > +# The point of this test is to test installing to a disk that contains > +# a partition that used to be a RAID member where the other parts of > +# the RAID are not present (the scenario is that the disk was just > +# grabbed out of a pile of previously used disks and shoved into a > +# server). > + > +# So what it does is to create a RAID0 out of partitions on two disks, > +# stop the RAID, wipe the superblock on one of them and then install > +# to the other using a standard partitioning scheme. > + > +bucket: > + - &setup | > + parted /dev/disk/by-id/virtio-disk-a --script -- \ > + mklabel msdos \ > + mkpart primary 1MiB 3073MiB \ > + mkpart extended 3074MiB 8193MiB \ > + mkpart logical 3075MiB 5122MiB \ > + mkpart logical 5123MiB 8192MiB \ > + set 1 boot on > + udevadm settle > + > +early_commands: > + 00-setup-raid: [sh, -exuc, *setup] Yes, thanks. > + > + > +showtrace: true > +storage: > + version: 1 > + config: > + - id: sda > + type: disk > + ptable: msdos > + model: QEMU HARDDISK > + serial: disk-a > + name: main_disk > + preserve: true > + grub_device: true > + - id: sdb > + type: disk > + ptable: msdos > + model: QEMU HARDDISK > + serial: disk-b > + name: extra_disk > + wipe: superblock-recursive > + - id: sda1 > + type: partition > + number: 1 > + size: 3072M > + device: sda > + flag: boot > + preserve: true > + wipe: superblock > + - id: sda2 > + type: partition > + number: 2 > + size: 5119M > + flag: extended > + device: sda > + preserve: true > + - id: sda5 > + type: partition > + number: 5 > + size: 2047M > + flag: logical > + device: sda > + preserve: true > + wipe: superblock > + - id: sda6 > + type: partition > + number: 6 > + size: 3069M > + flag: logical > + device: sda > + preserve: true > + wipe: superblock > + - id: sdb1 > + type: partition > + number: 1 > + size: 4GB > + device: sdb > + - id: volgroup1 > + name: vg1 > + type: lvm_volgroup > + devices: > + - sda5 > + - sda6 > + - id: lvmpart1 > + name: lv1 > + size: 1G > + type: lvm_partition > + volgroup: volgroup1 > + - id: lvmpart2 > + name: lv2 > + type: lvm_partition > + volgroup: volgroup1 > + - id: volgroup2 > + name: ubuntu-vg > + type: lvm_volgroup > + devices: > + - sdb1 > + - id: ubuntulv1 > + name: my-storage > + size: 1G > + type: lvm_partition > + volgroup: volgroup2 > + - id: sda1_root > + type: format > + fstype: ext4 > + volume: sda1 > + - id: lv1_fs > + name: storage > + type: format > + fstype: fat32 > + volume: lvmpart1 > + - id: lv2_fs > + name: storage > + type: format > + fstype: ext3 > + volume: lvmpart2 > + - id: sda1_mount > + type: mount > + path: / > + device: sda1_root > + - id: lv1_mount > + type: mount > + path: /srv/data > + device: lv1_fs > + - id: lv2_mount > + type: mount > + path: /srv/backup > + device: lv2_fs No, it is longer. I re-used lvm.yaml which was one of the existing, known working dos with extended/logical partitions. This is lvm.yaml with just the preserve decorations needed. I can drop the lvm bits and just use filesystems on partitions. -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383180 Your team curtin developers is requested to review the proposed merge of ~raharper/curtin:fix/block-sfdisk-parsing into curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
