On Thu, Dec 10, 2020, 02:41 Michael Hudson-Doyle <[email protected]> wrote:
> Thanks the tests are much nicer but I still have a question I'm afraid. > Hopefully close now :) > > Diff comments: > > > diff --git a/tests/unittests/test_apt_source.py > b/tests/unittests/test_apt_source.py > > index 6556399..e40d05d 100644 > > --- a/tests/unittests/test_apt_source.py > > +++ b/tests/unittests/test_apt_source.py > > @@ -33,6 +33,21 @@ S0ORP6HXET3+jC8BMG4tBWCTK/XEZw== > > =ACB2 > > -----END PGP PUBLIC KEY BLOCK-----""" > > > > +EXPECTEDKEY_NOVER = u"""-----BEGIN PGP PUBLIC KEY BLOCK----- > > + > > +mI0ESuZLUgEEAKkqq3idtFP7g9hzOu1a8+v8ImawQN4TrvlygfScMU1TIS1eC7UQ > > +NUA8Qqgr9iUaGnejb0VciqftLrU9D6WYHSKz+EITefgdyJ6SoQxjoJdsCpJ7o9Jy > > +8PQnpRttiFm4qHu6BVnKnBNxw/z3ST9YMqW5kbMQpfxbGe+obRox59NpABEBAAG0 > > +HUxhdW5jaHBhZCBQUEEgZm9yIFNjb3R0IE1vc2VyiLYEEwECACAFAkrmS1ICGwMG > > +CwkIBwMCBBUCCAMEFgIDAQIeAQIXgAAKCRAGILvPA2g/d3aEA/9tVjc10HOZwV29 > > +OatVuTeERjjrIbxflO586GLA8cp0C9RQCwgod/R+cKYdQcHjbqVcP0HqxveLg0RZ > > +FJpWLmWKamwkABErwQLGlM/Hwhjfade8VvEQutH5/0JgKHmzRsoqfR+LMO6OS+Sm > > +S0ORP6HXET3+jC8BMG4tBWCTK/XEZw== > > +=ACB2 > > +-----END PGP PUBLIC KEY BLOCK-----""" > > + > > +EXPECTED_BINKEY = u"s390x" > > So this value appears as the expected value in some asserts, but nothing > that I can see would make it the seen value in any of these asserts, so is > there some missing coverage? In any case, can you make this something more > realistic please :) > Yep, good catch! I see what's wrong with the test now and can fix it shortly. -- https://code.launchpad.net/~nacc/curtin/+git/curtin/+merge/393661 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
