> This looks mostly OK to me. Do you need to invoke parted at all though? I
> guess if you let sfdisk do it all, you have to do the resizefs calls downs
> before the sfdisk invocation and the resize ups after. I think I'd still
> prefer that though.
Agree. Done.
> Also this clearly only works for ext{2,3,4} filesystems. What's the long term
> plan there?
Let verify_format be aware of the resize, and complain if the partition to
resize is in an unsupported format. Ship the initial pull with just
ext{2,3,4}. Document the formats we can resize. Later PRs can be as needed
and focused on just the new filesystem type we want to resize. Next is almost
certainly NTFS.
What's your thoughts on the 'resize' keyword? I'm kind of leaning now for
leaving it as is, and if we later support move, adding a 'move' keyword as well.
--
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/417829
Your team curtin developers is requested to review the proposed merge of
~dbungert/curtin:resize into curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
