> Would you update doc/topics/config.rst?
Done.
> Also, I really like the 'extra-rsync-args' spelling a lot more than
> 'extra_rsync_args'.
I definitely prefer hyphens to underscores in YAML.
> That said, all other configuration directives under
> 'install' are spelled like the latter (i.e., with underscores to separate
> words) so it feels a bit out of place at the moment.
Yes, this is fair. I changed it to be ugly and consistent.
> Do we have a plan going forward?
Not really! Maybe we should make one.
> I'd like to deprecate all `configuration_directives` in favor of
> `configuration-directives`
I think this something we should consider.
> using code like:
>
> resume_data = install_cfg.get('resume-data', install_cfg.get('resume_data'))
> save_install_logs = install_cfg.get('save-install-logs',
> install_cfg.get('save_install_logs'))
Please not with code like that though :-)
> What do you think?
I would like some kind of explicit schema for curtin config, I think, whether
this is actual jsonschema or attr.s-style classes or something else. This
should (a) include default values for things (b) enable us to pass actual
config objects around rather than dictionaries everywhere. This is, uh,
slightly out of scope for this merge proposal though!
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/444008
Your team curtin developers is requested to review the proposed merge of
~mwhudson/curtin:extra-rsync-args into curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
