Review: Approve
Diff comments:
> diff --git a/curtin/config.py b/curtin/config.py
> index 2106b23..9b992fc 100644
> --- a/curtin/config.py
> +++ b/curtin/config.py
> @@ -126,4 +128,22 @@ def value_as_boolean(value):
> false_values = (False, None, 0, '0', 'False', 'false', 'None', 'none',
> '')
> return value not in false_values
>
> +
> +@attr.s(auto_attribs=True)
> +class GrubConfig:
This isn't the full set of grub config options, but that doesn't have to be
this MP.
> + remove_old_uefi_loaders: bool = True
> + reorder_uefi: bool = True
> + reorder_uefi_force_fallback: bool = attr.ib(
> + default=False, converter=value_as_boolean)
> + remove_duplicate_entries: bool = True
> +
> +
> +def fromdict(cls, d):
> + kw = {}
> + for field in attr.fields(cls):
> + if field.name in d:
> + kw[field.name] = d[field.name]
> + return cls(**kw)
> +
> +
> # vi: ts=4 expandtab syntax=python
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/444530
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
