jayvenn21 opened a new pull request, #543: URL: https://github.com/apache/airavata-custos/pull/543
## Summary - use Base UI's menu link item for the account-menu Settings link so it navigates reliably - include the settings fixture roles in the role MSW catalog so `/roles/:roleId` resolves for the Settings access card - make the settings e2e wait on DOM readiness and the visible page controls instead of the full browser load event ## Root cause PR #524 added a role-management MSW handler for `/roles/:roleId`. That handler shadowed the Settings fixture role details for `role-admin` and `role-amie`, so the Settings access card could fail to render its role/privilege sections. The account menu also rendered Settings as a regular menu item with a nested link, which Base UI did not activate reliably in the e2e path. ## Testing - `PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm test:e2e tests/settings.e2e.ts` - `PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm typecheck` - `PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm lint` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
