yasithdev opened a new pull request, #607:
URL: https://github.com/apache/airavata-custos/pull/607
Stacked on #605.
What's Fixed:
- Status-filtered trace lists returned a `total` that ignored the filter and
pages that came back short or empty, because status was checked after counting
and paging. The filter now narrows to matching traces first. The traces page
filters on `error` by default, so this affected almost every visit.
- `GET /audit/traces/{id}` had no trace-level status, so the trace view
could only show its root event's status. It now returns `status`, computed the
same way as in the list.
- Trace and span ids were declared `CHAR(n)`, so a blank id read back as
spaces. Root spans then looked like orphans, and untraced event deliveries
carried a blank trace id that the worker rejected as invalid.
`audit_events.trace_id`, `span_id`, `parent_span_id` and `events.trace_id` are
now declared `VARCHAR` in migrations `000005` and `000007`. Databases that
already applied those migrations keep `CHAR` until they are recreated.
- The AMIE packet timeline showed permanently failed decode events as
handled and succeeded, and queued or retrying ones as succeeded. These now map
to FAILED and RUNNING.
- Approving or rejecting a change request with only `change_status` and
`approver_id` reset the requested SU amount to 0, blanked the requested status
and reason, and recorded a 0-SU allocation diff. Fields left out of the update
now keep their stored values.
- `GET /compute-allocation-change-requests` had no API annotation, so the
generated SDK had no function for it.
Integration tests cover the status-filtered total and paging, root span
detection, the trace-level status, delivery trace ids, and approval keeping its
requested fields. A unit test covers the AMIE status mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
