So first off, thanks to geoffroy for taking the time to do this. It's nice
to have more of our ports scripts actually making use of the rc.d
framework.
There are however a couple of problems with the script. The most serious
is that all of the examples of "/usr/local" need to be changed to
%%PREFIX%% so that if a user has a different prefix set it will still
work. There are other elements it would be nice to improve, please see
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for more information.
To the maintainer, can you please approve at least the change to
%%PREFIX%% so that we can fix that ASAP?
Thanks,
Doug
On Wed, 31 Mar 2010, Pav Lucistnik wrote:
pav 2010-03-31 20:58:26 UTC
FreeBSD ports repository
Modified files:
net-mgmt/nfsen Makefile
Added files:
net-mgmt/nfsen/files nfsen.in patch-libexec_NfSenRRD.pm
Removed files:
net-mgmt/nfsen/files nfsen.sh.in
Log:
- Provide rc.subr script
PR: ports/144384 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144384
Submitted by: geoffroy desvernay <d...@centrale-marseille.fr>
Approved by: maintainer
- Allow to work with rrdtool 1.4.x
PR: ports/144876 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144876
Submitted by: Vincent Hoffman <vi...@unsane.co.uk>
Approved by: maintainer
Revision Changes Path
1.16 +3 -1 ports/net-mgmt/nfsen/Makefile
1.1 +24 -0 ports/net-mgmt/nfsen/files/nfsen.in (new)
1.3 +0 -86 ports/net-mgmt/nfsen/files/nfsen.sh.in (dead)
1.1 +11 -0 ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm (new)
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/Makefile.diff?&r1=1.15&r2=1.16&f=h
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.in
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/nfsen.sh.in
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm
--
Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/
Computers are useless. They can only give you answers.
-- Pablo Picasso
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
