On 2/9/07, Brooks Davis <[EMAIL PROTECTED]> wrote:
On Fri, Feb 09, 2007 at 01:15:17PM -0800, John-Mark Gurney wrote: > Brooks Davis wrote this message on Fri, Feb 09, 2007 at 19:03 +0000: > > brooks 2007-02-09 19:03:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/conf GENERIC > > sys/i386/conf GENERIC > > sys/ia64/conf GENERIC > > sys/pc98/conf GENERIC > > sys/powerpc/conf GENERIC > > sys/sparc64/conf GENERIC > > sys/sun4v/conf GENERIC > > Log: > > Include GEOM_LABEL in GENERIC. It's very useful and not well publicized > > enough. > > > > Approved by: pjd > > Can anyone think of a good place to put a warning about using labels > along w/ gmirror? I've had a case recently where I was loading g_label, > but forgot to load g_mirror... Since I was using ufs labels, my fs > mounted perfectly fine, but was mounting only one part of the g_mirror.. > I finally found this out when g_label decided to randomly use the other > disk one boot... > > Maybe g_label should not expose duplicate labels? That or duplicate lables should be uniquified some how. -- Brooks
I prefer that last option. Uniquify them somehow, and perhaps spit a warning out to console. "LABEL: ufs/xxxx on device ad4s1b renamed to ufs/xxxx1". Maybe just force it to auto-increment that last number until it finds an available slot. If it can't find an available slot, then spit out an error about ambiguous GEOM labels.... -- Coleman Kane _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
