Repository : ssh://darcs.haskell.org//srv/darcs/ghc On branch : master
http://hackage.haskell.org/trac/ghc/changeset/8b3bfb2ec41fd0e807a8f6e7a823795eafca1dcb >--------------------------------------------------------------- commit 8b3bfb2ec41fd0e807a8f6e7a823795eafca1dcb Author: Edward Z. Yang <[email protected]> Date: Mon Jun 13 17:17:10 2011 +0100 Remove unused assignArguments and argumentsSize. Signed-off-by: Edward Z. Yang <[email protected]> >--------------------------------------------------------------- compiler/cmm/CmmCallConv.hs | 16 +--------------- compiler/cmm/cmm-notes | 3 +-- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/compiler/cmm/CmmCallConv.hs b/compiler/cmm/CmmCallConv.hs index 830c879..73ce529 100644 --- a/compiler/cmm/CmmCallConv.hs +++ b/compiler/cmm/CmmCallConv.hs @@ -1,9 +1,7 @@ module CmmCallConv ( ParamLocation(..), ArgumentFormat, - assignArguments, - assignArgumentsPos, - argumentsSize, + assignArgumentsPos ) where #include "HsVersions.h" @@ -31,10 +29,6 @@ instance (Outputable a) => Outputable (ParamLocation a) where type ArgumentFormat a b = [(a, ParamLocation b)] -assignArguments :: (a -> CmmType) -> [a] -> ArgumentFormat a WordOff --- Stack parameters are returned as word offsets. -assignArguments _ _ = panic "assignArguments only used in dead codegen" -- assignments - -- | JD: For the new stack story, I want arguments passed on the stack to manifest as -- positive offsets in a CallArea, not negative offsets from the stack pointer. -- Also, I want byte offsets, not word offsets. @@ -97,14 +91,6 @@ assignArgumentsPos conv arg_ty reps = assignments size = (((widthInBytes w - 1) `div` wORD_SIZE) + 1) * wORD_SIZE off' = offset + size - -argumentsSize :: (a -> CmmType) -> [a] -> WordOff -argumentsSize f reps = maximum (0 : map arg_top args) - where - args = assignArguments f reps - arg_top (_, StackParam offset) = -offset - arg_top (_, RegisterParam _) = 0 - ----------------------------------------------------------------------------- -- Local information about the registers available diff --git a/compiler/cmm/cmm-notes b/compiler/cmm/cmm-notes index 98c2e83..0800bfb 100644 --- a/compiler/cmm/cmm-notes +++ b/compiler/cmm/cmm-notes @@ -1,7 +1,6 @@ More notes (June 11) ~~~~~~~~~~~~~~~~~~~~ -* Kill dead code assignArguments, argumentsSize in CmmCallConv. - Bake in ByteOff to ParamLocation and ArgumentFormat +* Bake in ByteOff to ParamLocation and ArgumentFormat CmmActuals -> [CmmActual] similary CmmFormals * Possible refactoring: Nuke AGraph in favour of _______________________________________________ Cvs-ghc mailing list [email protected] http://www.haskell.org/mailman/listinfo/cvs-ghc
