[svn:parrot] r21477 - branches/reconfigure/lib/Parrot

[jkeenan]

Author: jkeenan
Date: Fri Sep 21 20:18:11 2007
New Revision: 21477

Modified:
   branches/reconfigure/lib/Parrot/Configure.pm

Log:
Revert change concerning ->description.  It broke 3 tests because this is a 
method returning a package variable rather than a 'get the attribute' method.

Modified: branches/reconfigure/lib/Parrot/Configure.pm
==============================================================================
--- branches/reconfigure/lib/Parrot/Configure.pm        (original)
+++ branches/reconfigure/lib/Parrot/Configure.pm        Fri Sep 21 20:18:11 2007
@@ -299,9 +299,7 @@
     }
     my $step = $step_name->new();
 
-    unless ( $step->description() ) {
-        $step->description() = q{};
-    }
+    my $description = $step->description() || q{};
 
     # set per step verbosity
     if ( defined $args->{verbose_step} ) {
@@ -322,7 +320,7 @@
                 or
             (
                 # by description
-                $step->description =~ /$args->{verbose_step}/
+                $description =~ /$args->{verbose_step}/
             )
         ) {
             $conf->options->set( verbose => 2 );
@@ -332,7 +330,7 @@
     # RT#43673 cc_build uses this verbose setting, why?
     $conf->data->set( verbose => $args->{verbose} ) if $args->{n} > 2;
 
-    print "\n", $step->description, '...';
+    print "\n", $description, '...';
     print "\n" if $args->{verbose} && $args->{verbose} == 2;
 
     my $ret;
@@ -357,7 +355,7 @@
             _finish_printing_result( {
                 step        => $step,
                 args        => $args,
-                description => $step->description,
+                description => $description,
             } );
             # reset verbose value for the next step
             $conf->options->set( verbose => $args->{verbose} );