Update of /var/cvs/contributions/didactor2/src/education/templates/education
In directory james.mmbase.org:/tmp/cvs-serv3272

Modified Files:
        tree.jspx 
Log Message:
added some comments only


See also: 
http://cvs.mmbase.org/viewcvs/contributions/didactor2/src/education/templates/education


Index: tree.jspx
===================================================================
RCS file: 
/var/cvs/contributions/didactor2/src/education/templates/education/tree.jspx,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -b -r1.15 -r1.16
--- tree.jspx   24 Jan 2008 10:16:10 -0000      1.15
+++ tree.jspx   24 Jan 2008 10:35:27 -0000      1.16
@@ -18,6 +18,10 @@
 
     -->
 
+    <!--
+         Some tests can be made already.
+         Store those in variable for easy reference with mm:contains.
+    -->
     <di:copybook>
       <mm:relatednodescontainer path="madetests,tests"  element="tests">
         <mm:constraint field="madetests.score" operator="ge" value="0" />
@@ -25,10 +29,16 @@
       </mm:relatednodescontainer>
     </di:copybook>
 
+    <!--
+         Some learnblocks can be 'blocked'
+         Store those in variable for easy reference with mm:contains.
+    -->
     <mm:node number="$user">
       <mm:nodelistfunction referids="education" name="blockedLearnBlocks" 
id="blocked" />
     </mm:node>
 
+
+    <!-- 'the_only_node_to_show' functionality seems to cause a lot of noise 
-->
     <mm:import externid="the_only_node_to_show"/>
     <mm:present referid="the_only_node_to_show">
       <mm:node number="$the_only_node_to_show">
@@ -36,9 +46,22 @@
       </mm:node>
     </mm:present>
 
+    <!--
+        I don't know where this var is for.
+    -->
     <mm:import externid="learnobjecttype" />
+    <!--
+        I don't know where this var is for.
+    -->
     <mm:import externid="fb_madetest"/>
 
+
+    <!--
+        TODO: These things seem to be related to a didactor 'style' which you 
may want to override.
+              Perhaps it is an idea to determin these things in the filter, 
and provide it as
+              requestScope.style.gfx.item_opened and so on.
+              No need for ugly imports like this then any more.
+    -->
     <mm:import id="gfx_item_opened"><mm:treefile 
page="/gfx/icon_arrow_tab_open.gif" objectlist="$includePath" /></mm:import>
     <mm:import id="gfx_item_closed"><mm:treefile 
page="/gfx/icon_arrow_tab_closed.gif" objectlist="$includePath" /></mm:import>
     <!-- TODO some learnblocks/learnobjects may not be visible because the are 
not ready for elearning (start en stop mmevents) -->
@@ -68,9 +91,11 @@
             type="learnobjects" role="posrel">
           <mm:sortorder field="posrel.pos" direction="up"/>
           <mm:import id="showsubtree" reset="true">true</mm:import>
+
           <mm:tree type="learnobjects"
                    role="posrel" searchdir="destination" orderby="posrel.pos" 
directions="up"
                    maxdepth="${di:setting('education', 'max_depth') + 1}">
+
             <c:if test="${(empty path) or mm:contains(path, _node.number)}">
               <mm:nodeinfo type="type" id="nodetype" write="false" />
               <mm:depth id="currentdepth">
@@ -140,7 +165,9 @@
                 <mm:remove referid="previousnumber"/>
                 <mm:field id="previousnumber" name="number" write="false" />
 
-                <!-- determine if we may show this learnobject and its 
children -->
+                <!-- determine if we may show this learnobject and its children
+                     This is determined by related mmevents, iow, this is the 
implementation of an embargo.
+                -->
                 <di:getvalue component="education" name="showlo" 
arguments="${previousnumber}">
                   <!-- if 'showlo' is 0, then we may not show the subtree, so 
we ignore everything with a depth HIGHER than the current depth -->
                   <mm:compare value="0">
@@ -152,7 +179,9 @@
 
                 <mm:compare referid="showsubtree" value="true">
 
-                  <!-- have to skip the first entrance in scorm tree -->
+                  <!--
+                       have to skip the first entrance in scorm tree
+                  -->
                   <mm:compare referid="block_this_first_htmlpage" 
value="false">
                     <mm:compare referid="nodetype" 
valueset="educations,learnblocks,tests,pages,flashpages,preassessments,postassessments,htmlpages">
                       <div
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs

Reply via email to