Update of /var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/service In directory james.mmbase.org:/tmp/cvs-serv30319/dataconversion/src/java/com/finalist/cmsc/dataconversion/service
Modified Files: NodeService.java ConversionThread.java Conversion.java Log Message: CMSC-907 Code Quality with PMD Add final modifier to Util classes Add final modifier to Logger instances Change Boolean, Integer and Long instantiation to valueOf calls See also: http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/service See also: http://www.mmbase.org/jira/browse/CMSC-907 Index: NodeService.java =================================================================== RCS file: /var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/service/NodeService.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -b -r1.3 -r1.4 --- NodeService.java 7 May 2008 11:45:51 -0000 1.3 +++ NodeService.java 16 May 2008 11:45:45 -0000 1.4 @@ -27,7 +27,7 @@ */ public class NodeService { - private static Logger log = Logging.getLoggerInstance(NodeService.class.getName()); + private static final Logger log = Logging.getLoggerInstance(NodeService.class.getName()); /** * insert one record into cmsc db. Index: ConversionThread.java =================================================================== RCS file: /var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/service/ConversionThread.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -b -r1.1 -r1.2 --- ConversionThread.java 6 May 2008 11:05:49 -0000 1.1 +++ ConversionThread.java 16 May 2008 11:45:45 -0000 1.2 @@ -8,7 +8,7 @@ public class ConversionThread extends Thread{ - private static Logger log = Logging.getLoggerInstance(ConversionThread.class.getName()); + private static final Logger log = Logging.getLoggerInstance(ConversionThread.class.getName()); Properties properties; Index: Conversion.java =================================================================== RCS file: /var/cvs/contributions/CMSContainer_Modules/dataconversion/src/java/com/finalist/cmsc/dataconversion/service/Conversion.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -b -r1.1 -r1.2 --- Conversion.java 6 May 2008 11:05:49 -0000 1.1 +++ Conversion.java 16 May 2008 11:45:45 -0000 1.2 @@ -25,7 +25,7 @@ public class Conversion { - private static Logger log = Logging.getLoggerInstance(Conversion.class.getName()); + private static final Logger log = Logging.getLoggerInstance(Conversion.class.getName()); private static final String IMPORT_FILE = "import.xml"; private Properties properties; _______________________________________________ Cvs mailing list Cvs@lists.mmbase.org http://lists.mmbase.org/mailman/listinfo/cvs