Update of /var/cvs/contributions/natmm/src/nl/leocms/evenementen/stats
In directory james.mmbase.org:/tmp/cvs-serv7362/src/nl/leocms/evenementen/stats
Modified Files:
ExcelWriter.java
Log Message:
NMCMS-551 - Optimize and fix heavy database operations.
See also:
http://cvs.mmbase.org/viewcvs/contributions/natmm/src/nl/leocms/evenementen/stats
See also: http://www.mmbase.org/jira/browse/NMCMS-551
Index: ExcelWriter.java
===================================================================
RCS file:
/var/cvs/contributions/natmm/src/nl/leocms/evenementen/stats/ExcelWriter.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- ExcelWriter.java 21 Nov 2007 12:49:11 -0000 1.8
+++ ExcelWriter.java 18 Sep 2008 12:04:02 -0000 1.9
@@ -76,11 +76,12 @@
WritableWorkbook workbook = Workbook.createWorkbook(new
File(NatMMConfig.getTempDir() + fileName));
NodeList nl = ev.getSortedList(cloud, sParentEvent);
- NodeList nls =
cloud.getList(sParentEvent,"evenement,partrel,evenement1,posrel,inschrijvingen","evenement1.number,evenement1.begindatum",null,"evenement1.begindatum","UP",null,true);
- boolean bOneDateWithoutSubscriptions = (nl.size()!= nls.size());
+// ** Don't use very database intensive code that is not needed,
if-statement will always be executed.
+// NodeList nls =
cloud.getList(sParentEvent,"evenement,partrel,evenement1,posrel,inschrijvingen","evenement1.number,evenement1.begindatum",null,"evenement1.begindatum","UP",null,true);
+// boolean bOneDateWithoutSubscriptions = (nl.size()!= nls.size());
int j = 0;
- if(bOneDateWithoutSubscriptions) {
- String sThisEvenementNumber =
(String)nl.getNode(0).getStringValue("evenement1.number");
+// if(bOneDateWithoutSubscriptions) {
+// String sThisEvenementNumber =
(String)nl.getNode(0).getStringValue("evenement1.number");
HtmlCleaner hc = new HtmlCleaner();
String sSheetTitle =
HtmlCleaner.stripText(nParentNode.getStringValue("titel"));
if (sSheetTitle.length()>28) {
@@ -88,7 +89,7 @@
}
createEventDatesSheet(cloud,hc,nParentNode,workbook,j,sSheetTitle,
null);
j++;
- }
+// } ** //End of database intensive code.
for (int i = 0; i < nl.size(); i++){
Node event =
cloud.getNode(nl.getNode(i).getStringValue("evenement.number"));
if(event.getRelatedNodes("inschrijvingen").size()!=0) {
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs
