[MMBASE CVS] contributions/CMSContainer_Modules/community/src/java/com/finalist/cmsc/community/forms ReferenceImportExportAction.java SearchConditionalGroupAction.java

[nikkoyin]

Update of 
/var/cvs/contributions/CMSContainer_Modules/community/src/java/com/finalist/cmsc/community/forms
In directory james.mmbase.org:/tmp/cvs-serv21923

Modified Files:
        ReferenceImportExportAction.java 
        SearchConditionalGroupAction.java 
Log Message:
CMSC-899,Check and improve all lists according to guideline,add Javadoc comment


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/community/src/java/com/finalist/cmsc/community/forms
See also: http://www.mmbase.org/jira/browse/CMSC-899


Index: ReferenceImportExportAction.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer_Modules/community/src/java/com/finalist/cmsc/community/forms/ReferenceImportExportAction.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- ReferenceImportExportAction.java    23 Sep 2008 07:12:56 -0000      1.5
+++ ReferenceImportExportAction.java    23 Sep 2008 09:02:13 -0000      1.6
@@ -23,10 +23,22 @@
 import com.thoughtworks.xstream.XStream;
 import com.thoughtworks.xstream.io.xml.DomDriver;
 
+/**
+ * @author nikko
+ *
+ */
 public class ReferenceImportExportAction extends DispatchAction {
    private static Log log = 
LogFactory.getLog(ReferenceImportExportAction.class);
    private PersonService personService;
 
+   /**
+    * @param mapping do nothing 
+    * @param form do nothing 
+    * @param request do nothing 
+    * @param response setContentType
+    * @return ActionForward do nothing 
+    * @throws IOException toXML
+    */
    public ActionForward export(ActionMapping mapping, ActionForm form, 
HttpServletRequest request,
          HttpServletResponse response) throws IOException {
       log.debug("Export Susbscriptions");
@@ -44,6 +56,14 @@
       return mapping.findForward(null);
    }
 
+   /**
+    * @param mapping goto jsp
+    * @param form get paramate
+    * @param request save massages
+    * @param response do nothing
+    * @return ActionForward chose jsp
+    * @throws IOException about treating XML
+    */
    public ActionForward importsubscription(ActionMapping mapping, ActionForm 
form, HttpServletRequest request,
          HttpServletResponse response) throws IOException {
       ReferenceImportUploadForm myForm = (ReferenceImportUploadForm) form;
@@ -101,16 +121,16 @@
       return xstream;
    }
 
-   public static void setLog(Log log) {
+   private static void setLog(Log log) {
       ReferenceImportExportAction.log = log;
    }
 
-   public void setPersonService(PersonService personService) {
+   private void setPersonService(PersonService personService) {
       this.personService = personService;
 
    }
 
-   public static Log getLog() {
+   private static Log getLog() {
       return log;
    }
 }


Index: SearchConditionalGroupAction.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer_Modules/community/src/java/com/finalist/cmsc/community/forms/SearchConditionalGroupAction.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- SearchConditionalGroupAction.java   23 Sep 2008 07:12:56 -0000      1.7
+++ SearchConditionalGroupAction.java   23 Sep 2008 09:02:13 -0000      1.8
@@ -1,5 +1,6 @@
 package com.finalist.cmsc.community.forms;
 
+import java.io.IOException;
 import java.util.*;
 
 import javax.servlet.http.HttpServletRequest;
@@ -15,8 +16,19 @@
 import com.finalist.cmsc.services.community.security.Authentication;
 import com.finalist.cmsc.services.community.security.Authority;
 
+/**
+ * @author nikko
+ *
+ */
 public class SearchConditionalGroupAction extends AbstractCommunityAction {
 
+   /**
+    * @param mapping goto jsp
+    * @param form get paramate
+    * @param request setSharedAttributes
+    * @param response do nothing
+    * @return ActionForward chose jsp
+    */
    @Override
    public ActionForward execute(ActionMapping mapping, ActionForm form, 
HttpServletRequest request,
          HttpServletResponse response) throws Exception {
@@ -55,7 +67,7 @@
    }
 
    private List < GroupForShowVO > convertAuthrityTOVO(List < Authority > 
authorities) {
-      List < GroupForShowVO > groupForShow = new ArrayList < GroupForShowVO 
>();
+      List < GroupForShowVO > groupForShow = new ArrayList < GroupForShowVO > 
();
       for (Authority authority : authorities) {
          if (null != authority) {
             GroupForShowVO group = new GroupForShowVO();
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs