Update of
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services
In directory
james.mmbase.org:/tmp/cvs-serv7069/portlets-newsletter/src/java/com/finalist/newsletter/services
Modified Files:
CommunityModuleAdapter.java StatisticService.java
Log Message:
CMSC-907 - Clean up code: convert to better methods; fix naming convention
violations; remove extra imports.
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: CommunityModuleAdapter.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/CommunityModuleAdapter.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -b -r1.16 -r1.17
--- CommunityModuleAdapter.java 21 Oct 2008 07:25:57 -0000 1.16
+++ CommunityModuleAdapter.java 11 Feb 2009 09:08:11 -0000 1.17
@@ -75,7 +75,7 @@
public static String getUserNameByAuthenticationId(int authenticationId) {
AuthenticationService authenticationService = (AuthenticationService)
ApplicationContextFactory.getApplicationContext().getBean("authenticationService");
- com.finalist.cmsc.services.community.security.Authentication
authentication = authenticationService.getAuthenticationById(new
Long(authenticationId));
+ com.finalist.cmsc.services.community.security.Authentication
authentication =
authenticationService.getAuthenticationById(Long.valueOf(authenticationId));
if (authentication != null) {
return authentication.getUserId();
}
Index: StatisticService.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Portlets/portlets-newsletter/src/java/com/finalist/newsletter/services/StatisticService.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- StatisticService.java 28 Oct 2008 11:13:36 -0000 1.8
+++ StatisticService.java 11 Feb 2009 09:08:11 -0000 1.9
@@ -22,9 +22,9 @@
public StatisticResult statisticSummeryPeriod(String start, String end)
throws ServiceException;
- public StatisticResult StatisticSummaryByNewsletter(int newsletterId);
+ public StatisticResult statisticSummaryByNewsletter(int newsletterId);
- public List<StatisticResult> StatisticDetailByNewsletterPeriod(
+ public List<StatisticResult> statisticDetailByNewsletterPeriod(
int newsletterId, String start, String end) throws
ServiceException;
public void logPubliction(int newsletterId, HANDLE handle);
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs
