[EMAIL PROTECTED] wrote:
Author: tli
Date: Mon Sep 11 03:11:15 2006
New Revision: 442162

Modified: 
incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Endpoint.java
URL: 
http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Endpoint.java?view=diff&rev=442162&r1=442161&r2=442162
==============================================================================
--- incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Endpoint.java 
(original)
+++ incubator/cxf/trunk/api/src/main/java/org/apache/cxf/endpoint/Endpoint.java 
Mon Sep 11 03:11:15 2006
@@ -44,4 +44,6 @@
     Executor getExecutor();
Interceptor getFaultInterceptor(); + + Object getImplementor();
 }

I'm -1 on this change. Why is this on the Endpoint? It looks like you're looking up the method from the implementor methods and the class names, which isn't a real good way to do it. The BindingOperationInfo name should correspond to the rpc element name and the JaxWsServiceFactory should have already instantiated the operation with a Method. The invoker can then invoke the service by looking up the operation from the exchange. Also, there shouldn't be a need to look up the class as the Databinding is handling (see all the wrapped/bare interceptors for examples).

Cheers,
- Dan

--
Dan Diephouse
Envoi Solutions
http://envoisolutions.com
http://netzooid.com/blog

Reply via email to