+1 I agree.
We should add more unit/system tests to identify the problem.
Since you modified the code, can you create a jira task just describe
why it should be modified, what's the problem of previous code, and how
are you going to implement it?
And also add the unit/system tests to cover the scenario which previous
tests not covered.
And also should make sure the previous unit/system tests and demos are
working properly.
BTW, i'm really not fan of current modification, to reduce 10 lines of
code, we just added at least three classes and bunch of code, it's
really harder to maintain than the duplicated 10 lines of code.
Thanks.
James.
A good solution in my mind would be to write a unit test which tests
this functionality. Obviously, I'm going to have a hard time not
breaking things if they aren't tested at all. I'll take a look, but
it'd be great if you could add a failing unit test somewhere..
- Dan
Bozhong Lin wrote:
probably it is time now to setup nightly build and run CPI sanity
check regularly. I will looked into the possibility of porting Celtix
CPI test to CeltiXfire.
Cheers,
Bo
James Mao wrote:
Hi Dan,
I realized that you changed the code of dispatch/provider, and i
found that the demo not working now, Can you please take a look at
this.
Thanks in advance.
James.
Error message from dispatch_provider sample server:
[java] Exception in thread "main"
java.lang.NullPointerException: Could not find endpoint
GreeterDOMSourceMessageProviderPort in Service.
[java] at
org.apache.cxf.jaxws.EndpointImpl.<init>(EndpointImpl.java:95)
[java] at
org.apache.cxf.jaxws.spi.ProviderImpl.createEndpoint(ProviderImpl.java:57)
[java] at
org.apache.cxf.jaxws.spi.ProviderImpl.createAndPublishEndpoint(ProviderImpl.java:66)
[java] at javax.xml.ws.Endpoint.publish(Endpoint.java:156)
[java] at demo.hwDispatch.server.Server.<init>(Server.java:36)
[java] at demo.hwDispatch.server.Server.main(Server.java:45)
Error message from dispatch_provider sample client:
[java] Invoking server through Dispatch interface using DOMSource in
MESSAGE Mode
[java] Sep 27, 2006 4:51:18 PM
com.sun.xml.messaging.saaj.soap.SOAPPartImpl lookForEnvelope
[java] SEVERE: SAAJ0514: Unable to create envelope from given
source because the root element is not named Envelope
[java] Sep 27, 2006 4:51:18 PM
com.sun.xml.messaging.saaj.soap.EnvelopeFactory createEnvelope
[java] SEVERE: SAAJ0511: Unable to create envelope from given
source
[java] Response from server:
[java] Error 404 /SoapContext/SoapPort2 Not Found
[java] HTTP ERROR: 404/SoapContext/SoapPort2 Not Found
[java] RequestURI=/SoapContext/SoapPort2
[java] Powered by Jetty://
