Sure, but just want to say that people should still be cleaning up there
files. I think the best solution is to support streaming attachments
directly. And then if an attachment is saved, the user should be
responsible for cleaning up and deleting the files.
- Dan
Daniel Kulp wrote:
Another option might be to create a single "temporary directory" where all
the temp files are dumped. We can register a single exit hook that
cleans up the entire directory.
Dan
On Thursday November 09 2006 9:42 am, Peter Jones wrote:
Hi John,
On Thu, Nov 09, 2006 at 10:31:40AM +1100, John Sisson wrote:
FYI, deleteOnExit is known to consume memory that can lead to running
out of memory on a long running JVM. See
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4513817
Thanks for pointing this out, I should have considered that. PerhapsDan
we should do something about the file when the output stream is closed,
or it might be best to just rely on the caller ensuring the clean up
happens as Dan mentioned.
Cheers,
Peter
Regards,
John
Dan Diephouse wrote:
Hiya Peter,
Clean up looked good, just wanted to add two comments for the
general populace:
- I think people using attachments should clean up after
themselves. I'm not sure that we want to do file.deleteOnExit() -
what if the user just moves the file to a different location and
they want to keep it around as a saved attachment? this is probably
ok as a workaround for now though...
- It would be best if we streamed attachments directly off the
wire. This would remove our need to write an attachment to disk...
- Dan
[EMAIL PROTECTED] wrote:
Author: peterjones
Date: Mon Nov 6 19:16:59 2006
New Revision: 471975
URL: http://svn.apache.org/viewvc?view=rev&rev=471975
Log:
[CXF-184] some changes to account for parameter order of header
parts
- Added a test to the HeaderClientServerTest systest for CXF-184
- Work-around for not resolving relative imports in certain
circumstances
- Fixed problem with not deleting some temporary files
- Fixed some typos in comments and stuff
Modified:
incubator/cxf/trunk/api/src/main/java/org/apache/cxf/io/AbstractCa
chedOutputStream.java [...]
URL:
http://svn.apache.org/viewvc/incubator/cxf/trunk/api/src/main/java
/org/apache/cxf/io/AbstractCachedOutputStream.java?view=diff&rev=47
1975&r1=471974&r2=471975
--
Dan Diephouse
(616) 971-2053
Envoi Solutions LLC
http://netzooid.com
