On Wed, 11 Sep 2002, Corinna Vinschen wrote:
> astyle (NOT reviewed, 2 votes, Gareth and Lapo)
I did a review of the package itself, not of its feature. astyle contains
a lot of options and since I haven't used it in the past its not easy to
tell if specific options behaves as expected.
Ok, here is what I've found:
1) the names of the source and binary packages, the doc directory and
the source directories are not correct:
astyle_1.15.3-src.tar.bz2 => astyle-1.15.3-1-src.tar.bz2
astyle_1.15.3.tar.bz2 => astyle-1.15.3-1.tar.bz2
/usr/doc/astyle_1.15.3 => /usr/doc/astyle-1.15.3
/usr/doc/Cygwin/astyle_1.15.3.README => /usr/doc/Cygwin/astyle-1.15.3.README
/usr/src/astyle_1.15.3 => /usr/src/astyle-1.15.3-1
CYGWIN-PATCHES/astyle_1.15.3.README CYGWIN-PATCHES/astyle-1.15.3.README
CYGWIN-PATCHES/astyle_1.15.3.patch CYGWIN-PATCHES/astyle-1.15.3-1.patch
When fixing this the maintainer should also change the build receipt
in /usr/doc/Cygwin/astyle-1.15.3.README.
2) the source package includes astyle.exe
3) setup.hint contains a test entry (test: 1.2.17), but i don't recall
having this package as test in the Cygwin net distro, or am I wrong ?
4) the source package contains the patch in CYGWIN-PATCHES instead of
the root of the archive.
5) The patch was generated with CYGWIN-PATCHES containing the patch.
