On Sun, 16 Mar 2003, Robert Collins wrote: > Igor Pechtchanski wrote: > > The attached patch closes the unneeded handles in run() in script.cc. > > Those handles should be closed according to > > <http://msdn.microsoft.com/library/en-us/dllproc/base/createprocess.asp>: > > > > lpProcessInformation > > [out] Pointer to a PROCESS_INFORMATION structure that receives > > identification information about the new process. > > > > Handles in PROCESS_INFORMATION must be closed with CloseHandle > > when they are no longer needed. > > > > Feel free to reject if my understanding of the above is incorrect. > > Igor > > ============================================================================== > > ChangeLog: > > 2003-03-15 Igor Pechtchanski <[EMAIL PROTECTED]> > > > > * script.cc (run): Close unneeded handles. > > Applied
Rob, BTW, this may not matter, but I agree with Max and Pavel that it's nicer to close the thread handle before the process one. I've submitted the accordingly modified patch in <http://cygwin.com/ml/cygwin-apps/2003-03/msg00469.html>. If you think it doesn't matter, though, then leave it as-is. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ [EMAIL PROTECTED] ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED] |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk! -- /usr/games/fortune
