ChangeLog says it all really - this is just an incremental tweak to make it easier to create a "Finished" page, and to have all our font stylings in one place.
Note Gary had the SetDlgItemFont calls moved out in a seperate method. Given that they are almost the entire contents of the "case WM_INITDIALOG", I don't think this is appropriate. Max. +2003-07-31 Gary R. Van Sickle <[EMAIL PROTECTED]> + + Changes modified by Max Bowsher <[EMAIL PROTECTED]> + * splash.cc (Copyright): Update copyright dates. + (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in + base class. + * proppage.cc (Copyright): Update copyright dates. + (PropertyPage::DialogProc WM_INITDIALOG): Change font "MS Sans Serif" + to "MS Shell Dlg" in line with recent res.rc change. Set font for + IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of style for + future "Finished" page. Index: proppage.cc =================================================================== RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/proppage.cc,v retrieving revision 2.6 diff -u -p -r2.6 proppage.cc --- proppage.cc 30 Jul 2003 09:20:48 -0000 2.6 +++ proppage.cc 31 Jul 2003 12:05:58 -0000 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, Gary R. Van Sickle. + * Copyright (c) 2001, 2002, 2003 Gary R. Van Sickle. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -116,9 +116,12 @@ PropertyPage::DialogProc (UINT message, { OnInit (); - // Set header title font of each internal page to MS Sans Serif, Bold, 8 Pt. - // This will just silently fail on the first and last pages. - SetDlgItemFont(IDC_STATIC_HEADER_TITLE, "MS Sans Serif", 8, FW_BOLD); + // These font settings will just silently fail when the resource id + // is not present on a page. + // Set header title font of each internal page + SetDlgItemFont(IDC_STATIC_HEADER_TITLE, "MS Shell Dlg", 8, FW_BOLD); + // Set the font for the IDC_STATIC_WELCOME_TITLE + SetDlgItemFont(IDC_STATIC_WELCOME_TITLE, "Ariel", 12, FW_BOLD); // TRUE = Set focus to default control (in wParam). return TRUE; Index: splash.cc =================================================================== RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/splash.cc,v retrieving revision 2.11 diff -u -p -r2.11 splash.cc --- splash.cc 29 Jul 2003 14:14:06 -0000 2.11 +++ splash.cc 31 Jul 2003 11:49:30 -0000 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, Gary R. Van Sickle. + * Copyright (c) 2001, 2002, 2003 Gary R. Van Sickle. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -36,7 +36,4 @@ SplashPage::OnInit () ver.Format (IDS_VERSION_INFO, version[0] ? version : "[unknown]"); ::SetWindowText (GetDlgItem (IDC_VERSION), ver.c_str ()); - - // Set the font for the IDC_STATIC_WELCOME_TITLE - SetDlgItemFont(IDC_STATIC_WELCOME_TITLE, "Ariel", 12, FW_BOLD); }