Reini Urban wrote: > My first cygport package, great! > See > http://xarch.tu-graz.ac.at/publ/cygwin/release/postgresql/postgresql-8.1.3-2.cygport
Wow, cygport isn't even in the distro yet, but I'm glad to see the warm reception that it's gotten. :-) Overall, looks pretty good, and this is a complicated package. May I suggest a few minor changes for your next version: 1) Try to avoid overriding the *FLAGS variables, IOW: LDFLAGS="${LDFLAGS} -Wl,--enable-auto-image-base" Eventually there will be a better way to set package-specific *FLAGS. 2) I would use dolib and insinto/newins to simplify the src_install just a bit more, as well as using ${C}, which stands for ${S}/CYGWIN-PATCHES. (If the init.d script is supposed to be 755, then use exeinto/doexe instead.) src_install() { cd ${B} cyginstall docdir=/usr/share/doc/${P}/ # I prefer to have that in postgresql-devel already dolib ${B}/src/backend/libpostgres.a mv ${D}/usr/lib/*.dll ${D}/usr/bin/ dodir /usr/sbin for admin in createlang createuser droplang dropuser initdb \ pg_ctl pg_controldata pg_resetxlog pg_restore postgres \ postmaster vacuumdb; do mv ${D}/usr/bin/$admin.exe ${D}/usr/sbin/; done mv ${D}/usr/bin/ipcclean ${D}/usr/sbin/ insinto /etc/rc.d/init.d newins ${C}/postgresql.initd postgresql cp -r ${S}/doc/src/FAQ ${D}/usr/share/doc/${P}/ make -C contrib install DESTDIR=${D} bindir=/usr/lib/postgresql/bin/ docdir=/usr/share/doc/${P}/ } I hope this helps. Yaakov