Hi Chris,

On Dec 13 19:23, c...@sourceware.org wrote:
> CVSROOT:      /cvs/cygwin-apps
> Module name:  setup
> Changes by:   c...@sourceware.org     2009-12-13 19:23:43
> 
> Modified files:
>       .              : ChangeLog IniDBBuilder.h IniDBBuilderPackage.cc 
>                        IniDBBuilderPackage.h PickPackageLine.cc 
>                        PickView.cc install.cc package_meta.cc 
>                        prereq.cc package_version.cc package_version.h 
>                        package_meta.h inilex.ll iniparse.yy 
> 
> Log message:
>       * IniDBBuilder.h (buildMessage): Define for base class.
>       * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildMessage): Define.
>       * IniDBBuilderPackage.h (IniDBBuilderPackage::buildMessage): Declare.
>       * PickPackageLine.cc: Pass pointer to package to "pick" throughout, 
> where
>       appropriate.
>       * PickView.cc: Ditto.
>       * install.cc: Ditto.
>       * package_meta.cc: Ditto.
>       * prereq.cc: Ditto.
>       * package_version.cc: Ditto.
>       (packageversion::pick): Add pkg pointer as second argument.  Display 
> message
>       where appropriate.
>       * package_version.h (packageversion::pick): Add pkg pointer as second 
> argument.
>       * package_meta.h (packagemeta::mesage): Define.
>       (packagemeta::set_message): Define.
>       * inilex.ll: Properly return MESSAGE token.
>       * iniparse.yy: Handle message: keyword.

This patch seems to be incomplete.  Trying to build setup now results in
an error:

  In file included from choose.h:21,
                   from choose.cc:51:
  package_meta.h:27:29: package_message.h: No such file or directory
  In file included from choose.h:21,
                  from choose.cc:51:
  package_meta.h:146: error: `packagemessage' does not name a type
  package_meta.h: In member function `void packagemeta::set_message(const 
std::string&, const std::string&)':
  package_meta.h:91: error: `message' undeclared (first use this function)
  package_meta.h:91: error: (Each undeclared identifier is reported only once 
for each function it appears in.)
  make[2]: *** [choose.o] Error 1

There's actually no package_message.h file in the repository.  Could
you please check it in?

Btw., is setup finished for the 1.7.1 release with this patch or is
there more to come?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Reply via email to