On 30/07/2010 15:37, Christopher Faylor wrote:
On Thu, Jul 29, 2010 at 05:28:02PM +0100, Jon TURNEY wrote:
On 28/07/2010 15:58, Christopher Faylor wrote:
On Wed, Jul 28, 2010 at 03:25:17PM +0100, Jon TURNEY wrote:
Anyhow, here's another attempt, which unfortunately changes rather more than I
wanted to. It adds a new page, which is displayed if any script failed, and
reports which packages and scripts failed.
That is great. Please check in (with a ChangeLog of course).
I just gave you the ability to check into cygwin-apps and, if you want to update
the documentation to winsup/doc.
Thanks. I've checked in the changes to cygwin-apps.
I'll have a look at what documentation changes might be needed.
Jon, I just tried this and I'm getting a blank "Postinstall script
errors" page. The only two packages that should have been installed
were
gcc: C compiler upgrade helper
glib: Gnome C function library (1.2 sources)
(both of which are selected due to a setup.exe bug)
A brief glance at your new code seems to show that this is not intended
behavior. Do you have any idea why this is happening?
Looks like I managed to break it somewhere along the way. See patch.
Sorry about that.
On 29/07/2010 22:09, Andy Koppe wrote:
On 29 July 2010 20:39, Christopher Faylor wrote:
> On Thu, Jul 29, 2010 at 05:28:02PM +0100, Jon TURNEY wrote:
> I'm grateful that you and Andy have decided to take over
> setup.exe maintainership. I have a whole bunch of enhancement requests for
you.
Nice try, but no, Jon can have it all to himself. ;)
Andy.run(Direction::AWAY, Speed::VERY_HASTILY);
I think my shame at such a terrible mistake means I'll have to decline this
honour :-)
Index: postinstall.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/postinstall.cc,v
retrieving revision 2.24
diff -u -p -r2.24 postinstall.cc
--- postinstall.cc 29 Jul 2010 13:10:46 -0000 2.24
+++ postinstall.cc 30 Jul 2010 19:16:30 -0000
@@ -192,7 +192,7 @@ do_postinstall_reflector (void *p)
PostInstallResults.SetResultsString(s);
// Tell the progress page that we're done running scripts
- Progress.PostMessage (WM_APP_POSTINSTALL_THREAD_COMPLETE,
+ Progress.PostMessage (WM_APP_POSTINSTALL_THREAD_COMPLETE, 0,
s.empty() ? IDD_DESKTOP : IDD_POSTINSTALL);
}
TOPLEVEL_CATCH("postinstall");
