On 02/03/2015 16:32, Corinna Vinschen wrote: > On Mar 2 13:55, Jon TURNEY wrote: >> >> Future work: there are some other uses of msg() to report real errors. At >> the >> moment, these are completely invisible unless you are running setup under a >> debugger. These should be converted to use the logger. [...] > Approved, under the assumption that you'll rework the other msg() calls > as well ;)
:) Also change some of the uses of fprintf(stderr, ...) to report errors, which doesn't get logged. This then exposes a bit of log spam in archive_tar.cc, which is silenced. Jon TURNEY (4): Add Log adaptors for printf-style output Remove msg() and convert to log output Log errors from archive_tar.cc Silently ignore 'x' and 'g' type tar extended headers ChangeLog | 28 ++++++++++++++++++++++++++++ LogSingleton.cc | 28 ++++++++++++++++++++++++++++ LogSingleton.h | 5 +++++ archive_tar.cc | 28 ++++++++++++---------------- compress_xz.cc | 22 +++++++++++----------- crypto.cc | 5 +++-- desktop.cc | 13 ++++++------- gpg-packet.cc | 5 +++-- ini.cc | 3 +-- msg.cc | 10 ---------- msg.h | 6 ------ simpsock.cc | 8 ++++---- 12 files changed, 101 insertions(+), 60 deletions(-) -- 2.1.4