On Jul 21 09:50, Ken Brown wrote: > On 7/21/2022 5:09 AM, Corinna Vinschen wrote: > > We're using the "?p=" URLs on the cygin-apps website, too. Maybe it's > > just me, but to me it looks better if we change this to the 2nd form > > where possible. What do you think? > > I agree that it looks better without the ?p=. I have no idea why the latter > is used on the cygwin-apps website. > > > Just a style issue, but the two functions should stay first in the file. > > Please move this code just right before the trap call. > > > > Other than that, LGTM. > > I've made all the changes you suggested and pushed it.
Great, I pushed a patch to simplify the URLs and added a link from the Cygwin homepage to the cygwin apps homepage. Thanks, Corinna