Thank you for your review. > libhtp2_CONTENTS=" > usr/bin/*-2.dll > usr/share > " > > So that if and when the soversion changes, packaging fails, rather than > silently ploughing on to create a libhtp2 package containing > cyghtp-3.dll, with hilarious consequences.
That's a good idea. - https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/libhtp.git;a=blob;f=libhtp.cygport;h=6bde0aa62289a179b5c6c697c6ce621ec11de02d;hb=55abbe06056ffc608165e1904b78d540457d98bc#l33 On Wed, Apr 5, 2023 at 3:25 AM Jon Turney <jon.tur...@dronecode.org.uk> wrote: > > On 02/04/2023 15:17, Daisuke Fujimura via Cygwin-apps wrote: > > Hello, > > > > [ITP] A new package proposal: libhtp > > > > - libhtp2 > > - libhtp-devel > > Thanks! > > > > > ==== > > > > SUMMARY: Security-aware parser for the HTTP protocol > > HOMEPAGE: https://github.com/OISF/libhtp > > SRC_URI: https://github.com/OISF/libhtp/archive/refs/tags/0.5.42.tar.gz > > LICENSE: BSD-3-Clause > > > > ==== > > > > Corresponding Linux/Unix packages are searched: > > - https://repology.org/project/libhtp/versions > > > > Cygportfile: > > - > > https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/playground.git;a=shortlog;h=refs/heads/libhtp > > You might want to consider writing something like: > > libhtp2_CONTENTS=" > usr/bin/*-2.dll > usr/share > " > > So that if and when the soversion changes, packaging fails, rather than > silently ploughing on to create a libhtp2 package containing > cyghtp-3.dll, with hilarious consequences. > > > > > Packages, logs: > > - https://github.com/cygwin/scallywag/actions/runs/4587137631 > > > Otherwise, looks good. > > I added this to your packages. >
