Hi Jon, Thanks for revewing.
On Sat, 13 Jan 2024 15:48:33 +0000 Jon Turney wrote: > On 04/01/2024 00:55, Takashi Yano via Cygwin-apps wrote: > [...] > > Any comments and advices will be appreciated. > > Thanks for adopting this. > > > pocl.cygport > > > > inherit clang cmake > > > > NAME="pocl" > > VERSION=3.1 > > RELEASE=1 > > CATEGORY="Libs" > > # The entire code is under MIT > > # include/utlist.h which is under BSD-1-Clause (unbundled) > > # lib/kernel/vecmath which is under GPL-3.0-or-later OR LGPL-3.0-or-later > > LICENSE="MIT, BSD-1-Clause, GPL-3.0-or-later OR LGPL-3.0-or-later" > > I think this is going to fail to validate as an SPDX license expression. > The identifiers should be combined with AND and OR (where OR represents > a choice, and AND represents compliance with both alternatives is required). What about "MIT AND BSD-1-Clause AND (GPL-3.0-or-later OR LGPL-3.0-or-later)"? Is "()" allowed? > When I try to build it fails: > > [449/761] Linking CXX shared module lib/llvmopencl/cygllvmopencl.dll > FAILED: lib/llvmopencl/cygllvmopencl.dll > [...] > /usr/bin/ld: cannot find -lpocl: No such file or directory > clang-8: error: linker command failed with exit code 1 (use -v to see > invocation) > > I don't know if that means it's looking for the installed rather than > just built libpocl there, or something else is wrong. I cannot reproduce this even if I uninstall libpocl-devel. Umm, what is the difference? My environment is as follows. Cygwin Package Information Package Version Status binutils 2.41-3 OK clang 8.0.1-1 OK cmake 3.25.3-1 OK cygport 0.36.7-1 OK ninja 1.11.1-1 OK -- Takashi Yano <takashi.y...@nifty.ne.jp>
