Jon Turney via Cygwin-apps writes: > Thanks, this is great! You're welcome.
> Please, please make a patch with git format-patch, which I can then > just apply. You can always just pull it in from my repo… when it's ready. > Fifty lines of perl with no comments! This is just line noise to me > unless I spend lots of time staring at it :) That's what you get from an experiment that went rather more well than planned. > Seriously, this should at least say "I'm running objdump -Wl to dump > out the .debug_line section containing DWARF XYZ information. > > Then maybe some comments about what assumptions it's making about the > human-readable output it's parsing. So you're asking for a manpage, really. Should be doable with enough round tuits. > cygport goes to some lengths to identify the correct objdump to use > when cross-building, so it should probably should be used here (passed > in as an arg?), rather than assuming it's /usr/bin/objdump. Yes, either that or using whatever variable cygport sets up with the correct objdump. > What this line is doing is obvious, the rest of this block, not so much. Nothing to see here, move along… :-P > You might also like to touch on why we bother looking at the line > number information at all, rather than just producing a (filtered) > list of all the pathnames mentioned? I was using this to figure out why the "objdump -d -l" was missing some of the file names I was seeing (in general, again, it comes to the same set of files in the end). > If you're going to keep this (which you probably should), perhaps it > should be under some 'if (DEBUG)' conditional. Yeah, can do if I use GetOpt::Long, which I should probably do anyway just in case this gets extended later on. > DWARF_PARSE should be mentioned in the documentation for cygport.conf Yes. > Since the helper script will be installed, it could be made a boolean. Out of habit grown over decades, I always keep an escape hatch for using local (modified) copies in such scripts. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables
