On Aug 1 04:15, Yitzchak Scott-Thoennes wrote: > I don't have a serial device to test this with, but it's just selected > parts of the TIOCMSET handling slightly adapted.
I'm not serial I/O savvy, but the change looks pretty much ok. I'm just not exactly glad that the functionality itself is duplicated. Would you mind a rewrite so that the functionality is not copied, for instance by creating a private method which does it, or by recursively calling fhandler_serial::ioctl() with tweaked arguments (TIOCMSET)? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader mailto:cygwin@cygwin.com Red Hat, Inc.