-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Corinna Vinschen on 9/29/2009 1:35 PM: > On Sep 29 13:18, Eric Blake wrote: >> I missed one corner case in my testing; how about this followup? >> >> 2009-09-29 Eric Blake <e...@byu.net> >> >> * syscalls.cc (rename): Fix regression on rename("dir","d/"). > > Looks ok to me. Isn't that partly covered by the next if, though? > YA piece of code lacking comments it seems.
I added a few comments before committing. The difference between the two lines is that only the first one rejects rename("file","file2/"), and only the second rejects rename("dir","file"); both lines are needed. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrCvgcACgkQ84KuGfSFAYA1pQCgwfc9ayThRxR2LfXKdkRgAyHE zH4An1LF/FQwanbMRHuu1uCrv5a2RGIt =p2ej -----END PGP SIGNATURE-----