-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Christian Franke on 10/11/2009 2:45 PM: > 2009-10-11 Christian Franke <fra...@computer.org> > Corinna Vinschen <cori...@vinschen.de> > > * include/sys/cygwin.h: Add new cygwin_getinfo_type > CW_SET_EXTERNAL_TOKEN. > Add new enum CW_TOKEN_IMPERSONATION, CW_TOKEN_RESTRICTED.
Shouldn't we also bump version.h when adding new CW_ flags? > + case CW_SET_EXTERNAL_TOKEN: > + { > + HANDLE token = va_arg (arg, HANDLE); > + int type = va_arg (arg, int); > + set_imp_token (token, type); > + return 0; > + } Not the first time this is done in this function. But generally, shouldn't we follow the good practice of using va_end any time we used va_arg, in case cygwin is ever ported to a system where va_end is more than a no-op? [At least, I'm assuming that __builtin_va_end() is a no-op for x86?] - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrUbB4ACgkQ84KuGfSFAYAHOQCgt+MI1ALkqnMMwPX6QlJ7VwJZ mYMAn37mvgvZDZzBw27vXcKutLGwilpW =8hvQ -----END PGP SIGNATURE-----